Basic implementation for textDocument/documentLink#8446
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
odisseus
force-pushed
the
document-link
branch
2 times, most recently
from
9f7b009 to
ed20bc3
Compare
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
Do you think we could handle javadoc links as well?
| def getLinks( | ||
| filePath: AbsolutePath | ||
| ): util.List[DocumentLink] = { | ||
| val urlRegex = raw"https?:\/\/\S+".r |
There was a problem hiding this comment.
Could we use a scanner and extract comments, then only to look inside those comments? We would avoid running the regex on the whole file.
There was a problem hiding this comment.
This regex is very simple, so I don't think running it on every line is going to cause problems. Besides, URLs can also occur in string literals.
2 participants
No description provided.