resolve oneof field name conflicts with imported packages #1912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@thesamet do you think we should fork the library? |
Contributor
|
@i-am-the-slime help in maintenance could be appreciated. The PR did not run should CI tests for some reason. I was trying yesterday to see if this is related to mergify and made some related changes. Can you take a look? |
Include oneof field names in conflict detection to properly generate _root_ prefixes when oneof fields conflict with imported package names.
thesamet
force-pushed
the
fix-incorrect-import-generation-for-oneof
branch
from
023d59c to
91836b8
Compare
i-am-the-slime
added a commit
to i-am-the-slime/ScalaPB
that referenced
this pull request
Aug 22, 2025
The test was using OneofImportConflict but the generated class is OneofImportConflictTest. This fixes the compilation error in the e2e tests for PR scalapb#1912. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This was referenced Aug 22, 2025
Contributor
|
I tried to address this with some AI help here: #1947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
oneoffield names in conflict detection to properly generate root prefixes whenoneoffields conflict with imported package names.Closes #1911