Generate code using fully qualified type names #1971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently code generator produces code that uses fully qualified type names conditionally. This can cause shadowing of packages by local identifiers.
This is somewhat related to #1911, but there are more cases when this problem occurs.
For example:
Causes the following compilation error:
This PR changes code generator to always use fully qualified type names, which should prevent majority of cases where shadowing could cause a problem.