Skip to content

Adjust precision of mapped datatype for ScalarDB BIGINT on Oracle #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Mar 11, 2025

Description

ScalarDB BIGINT is mapped to Oracle's NUMBER(19) type. However, a lower precision of 16 digits is enough to accommodate the allowed maximum value 9007199254740992L and minimum value -9007199254740992L.

Related issues and/or PRs

N/A

Changes made

Change mapping of BIGINT datatype to Oracle NUMBER(16)

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

Release notes

ScalarDB BIGINT datatype will now be mapped to Oracle's NUMBER(16).

@Torch3333 Torch3333 force-pushed the reduce_precision_for_bigint_type_on_oracle branch from 0f153c1 to 722495f Compare March 12, 2025 03:38
@Torch3333 Torch3333 self-assigned this Mar 12, 2025
@Torch3333 Torch3333 changed the title Reduce precision of mapped dataype for ScalarDB BIGINT on Oracle Reduce precision of mapped datatype for ScalarDB BIGINT on Oracle Mar 19, 2025
@Torch3333 Torch3333 marked this pull request as ready for review March 19, 2025 04:24
@Torch3333 Torch3333 requested review from a team, komamitsu, brfrn169 and feeblefakie and removed request for a team March 19, 2025 04:24
@Torch3333 Torch3333 changed the title Reduce precision of mapped datatype for ScalarDB BIGINT on Oracle Adjust precision of mapped datatype for ScalarDB BIGINT on Oracle Mar 19, 2025
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants