-
Notifications
You must be signed in to change notification settings - Fork 38
Adjust precision of mapped datatype for ScalarDB BIGINT on Oracle #2566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…)` to `NUMBER(16)`
0f153c1
to
722495f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
ScalarDB BIGINT is mapped to Oracle's
NUMBER(19)
type. However, a lower precision of 16 digits is enough to accommodate the allowed maximum value9007199254740992L
and minimum value-9007199254740992L
.Related issues and/or PRs
N/A
Changes made
Change mapping of BIGINT datatype to Oracle
NUMBER(16)
Checklist
Additional notes (optional)
Release notes
ScalarDB BIGINT datatype will now be mapped to Oracle's NUMBER(16).