Close BufferedReader in process_withSingleCrudMode#3441
Open
tejasae-afk wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves resource management in ImportProcessorTest.java by wrapping a BufferedReader in a try-with-resources block to prevent potential leaks. The reviewer suggests applying this change consistently to other test methods in the same file that exhibit the same issue.
tejasae-afk
force-pushed
the
fix/close-bufferedreader-in-proces
branch
from
f2398cf to
43b40d8
Compare
Author
|
Updated — wrapped all remaining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be a small issue in process_withSingleCrudMode_shouldProcessAllDataChunks: The resource opened there can leak if process_withSingleCrudMode_shouldProcessAllDataChunks exits on an error path. this patch moves the allocation into try-with-resources so cleanup happens on every exit path. Let me know if I’m missing context.
Happy to revise the approach or close this if it doesn’t fit — you know the codebase far better than I do.