Backport to branch(3) : Accept JDBC connection string starting with "jdbc:spanner" used by Spanner Omni#3569
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the 'jdbc:spanner:' URL prefix in addition to the existing 'jdbc:cloudspanner:' prefix, updating both the integration test environment and the RdbEngineFactory. A new test class, RdbEngineFactoryTest, has been added to verify the factory's behavior across various JDBC URLs. I have reviewed the changes and suggest refactoring the repeated system property lookup in JdbcEnv.java into a local variable for improved efficiency and readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of the following:
Please merge this PR after all checks have passed.