List 1 #1
Open
List 1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abg4real
reviewed
Jul 8, 2022
| } | ||
|
|
There was a problem hiding this comment.
- remove empty lines
- the order of css rules should be first parent, then its childs/states like hover. For eg.
.cardshould come first, then.card:hoverand.card imageas such. - You can use css variables for values like color which is used again and again.
Abg4real
reviewed
Jul 8, 2022
main.js
Outdated
Comment on lines
51
to
60
| if(poster_path!=null){ | ||
| htmlData+=`<img src="${imgUrl +poster_path}" alt="${title}">`; | ||
| if(title.length>16){ | ||
| htmlData+=`<h3 class="card-item"> ${title.substring(0,17)}...</h3>`; | ||
| }else{ | ||
| htmlData+=`<h3 class="card-item"> ${title}</h3>` | ||
| } | ||
| htmlData+=`<button class ="btn"> Read More </button>` | ||
|
|
||
| div.innerHTML=htmlData |
There was a problem hiding this comment.
Although innerHTML is one of the ways you can directly add elements, it should be avoided due to various reasons..
You can create element and append it.
Abg4real
reviewed
Jul 8, 2022
main.js
Outdated
|
|
||
|
|
||
| async function getMovieFromApi(api) { | ||
| const response= await axios.get(api); |
There was a problem hiding this comment.
- Keep indentation consistent. You can use auto code formatters for that.
- Remove empty lines
Abg4real
reviewed
Jul 8, 2022
main.js
Outdated
| const query=event.target.value; | ||
|
|
||
| if(query.length>0){ | ||
| getMovieFromApi(searchUrl+"&query="+query); |
There was a problem hiding this comment.
You can just pass query in this function since variables like api and searchUrl are globally scoped.
The getMovieFromApi function will be something like:
async function getMovieFromApi(query='') {
const url = query==='' ? api : searchUrl+"&query="+query;
const response = await axios.get(url);
// rest of the code
}
|
The design for the poster is not as per the design. |
hhkk28
reviewed
Jul 13, 2022
| rel="stylesheet" | ||
| /> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| <title>Book Ticket</title> |
There was a problem hiding this comment.
👍 Great attention to detail
hhkk28
reviewed
Jul 13, 2022
| @@ -1,8 +1,168 @@ | |||
| :root { | |||
| --light-grey: #626262; | |||
hhkk28
reviewed
Jul 13, 2022
style.css
Outdated
| .heading { | ||
| font-family: "Roboto Mono"; | ||
| font-size: 48px; | ||
| font-weight: 250; |
There was a problem hiding this comment.
The font weight mentioned in the design in 400
hhkk28
reviewed
Jul 13, 2022
|
Great work @mr-meetpatel PR approved and you have completed your JS assignment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed JS assignment which is Movie LIst app using movie API.