Skip to content

fix(webhosting): add dns autoconfig none option #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025
Merged

fix(webhosting): add dns autoconfig none option #4602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd3fce1
feat: update generated APIs
scaleway-bot Mar 20, 2025
08a2c25
Merge branch 'master' into v1.6286.0
jremy42 Mar 20, 2025
b0e9e29
Merge branch 'master' into v1.6286.0
jremy42 Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-webhosting-domain-sync-dns-records-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ ARGS:
[auto-config-domain-dns.web-records] Whether or not to synchronize web records.
[auto-config-domain-dns.mail-records] Whether or not to synchronize mail records.
[auto-config-domain-dns.all-records] Whether or not to synchronize all types of records. Takes priority over the other fields.
[auto-config-domain-dns.none] No automatic domain configuration. Users must configure their domain for the Web Hosting to work.
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

DEPRECATED ARGS:
Expand Down
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-webhosting-hosting-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ ARGS:
[auto-config-domain-dns.web-records] Whether or not to synchronize web records.
[auto-config-domain-dns.mail-records] Whether or not to synchronize mail records.
[auto-config-domain-dns.all-records] Whether or not to synchronize all types of records. Takes priority over the other fields.
[auto-config-domain-dns.none] No automatic domain configuration. Users must configure their domain for the Web Hosting to work.
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
2 changes: 2 additions & 0 deletions docs/commands/webhosting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ scw webhosting domain sync-dns-records [arg=value ...]
| auto-config-domain-dns.web-records | | Whether or not to synchronize web records. |
| auto-config-domain-dns.mail-records | | Whether or not to synchronize mail records. |
| auto-config-domain-dns.all-records | | Whether or not to synchronize all types of records. Takes priority over the other fields. |
| auto-config-domain-dns.none | | No automatic domain configuration. Users must configure their domain for the Web Hosting to work. |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down Expand Up @@ -515,6 +516,7 @@ scw webhosting hosting create [arg=value ...]
| auto-config-domain-dns.web-records | | Whether or not to synchronize web records. |
| auto-config-domain-dns.mail-records | | Whether or not to synchronize mail records. |
| auto-config-domain-dns.all-records | | Whether or not to synchronize all types of records. Takes priority over the other fields. |
| auto-config-domain-dns.none | | No automatic domain configuration. Users must configure their domain for the Web Hosting to work. |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ require (
github.com/mattn/go-isatty v0.0.20
github.com/moby/buildkit v0.13.2
github.com/opencontainers/go-digest v1.0.0
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.32.0.20250319145910-2e85f595df2a
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.32.0.20250320132958-0f59cae533d0
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.9.1
github.com/spf13/pflag v1.0.6
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.32.0.20250319145910-2e85f595df2a h1:WH07M81Mx2nsB0BpE4jAp4ES9bJaVNcP2WaXYkQb6XA=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.32.0.20250319145910-2e85f595df2a/go.mod h1:792k1RTU+5JeMXm35/e2Wgp71qPH/DmDoZrRc+EFZDk=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.32.0.20250320132958-0f59cae533d0 h1:aqpUaCWx5ta43b9dZv1bMIvUUJTux9Am+S7RmJbiVN8=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.32.0.20250320132958-0f59cae533d0/go.mod h1:792k1RTU+5JeMXm35/e2Wgp71qPH/DmDoZrRc+EFZDk=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=
Expand Down
14 changes: 14 additions & 0 deletions internal/namespaces/webhosting/v1/webhosting_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,6 +819,13 @@ func webhostingDomainSyncDNSRecords() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "auto-config-domain-dns.none",
Short: `No automatic domain configuration. Users must configure their domain for the Web Hosting to work.`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
},
Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
Expand Down Expand Up @@ -1006,6 +1013,13 @@ func webhostingHostingCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "auto-config-domain-dns.none",
Short: `No automatic domain configuration. Users must configure their domain for the Web Hosting to work.`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(scw.RegionFrPar, scw.RegionNlAms, scw.RegionPlWaw),
},
Run: func(ctx context.Context, args interface{}) (i interface{}, e error) {
Expand Down
Loading