fix(instance): server: fix deletions in private_network list#3783
Draft
Mia-Cross wants to merge 3 commits intoscaleway:mainfrom
Draft
fix(instance): server: fix deletions in private_network list#3783Mia-Cross wants to merge 3 commits intoscaleway:mainfrom
Mia-Cross wants to merge 3 commits intoscaleway:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed unexpected behaviors in the
private_networklist attribute of the scaleway_instance_server resource.Notes:
pn_idempty) in the second part: when deleting 2 pn_ids out of 4, there are actually 3 PNs that are read from the user config by Terraform (including 1 phantom pn), then 4 again (2 phantoms) when checking resource attributes values.pn_id, but when reading the computed attributes, the element has new values inside and the hash changes. I attempted to avoid this by having a custom hash func that only considers thepn_id, but this seems to be what's generating the phantom elements.