Skip to content

Fix array types with generics #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

NicoKiaru
Copy link
Contributor

Adds a test that reproduces the issue #415

The test CommandArrayConverterTest#testArrayConvertFromStringCommandWildcardGenerics currently fails

@imagejan
Copy link
Member

@hinerm if you find the time, may I ask you to have a look at this? See the linked issues for context.

@imagejan imagejan changed the title adds test for string to array conversion in command Fix array types with generics Jan 19, 2021
@hinerm hinerm merged commit c7aa9f4 into scijava:master Jan 19, 2021
@hinerm
Copy link
Member

hinerm commented Jan 19, 2021

This was a delightfully effortless PR to review and merge. Thank you so much @imagejan, @NicoKiaru, @frauzufall!

@imagejan
Copy link
Member

@hinerm thanks a lot!

Did you merge locally? I would have expected the merge of this PR make #417 obsolete, but now it's still open because the commit hashes of the PR branches (both #416 and #417) are different from the ones on master 😕

Will close the other PR manually.

@NicoKiaru
Copy link
Contributor Author

@hinerm do you know if this fix made its way in pom-scijava 30.0.0 ? Or is it planned for 30.0.1 ? Or is it unrelated ?

@imagejan
Copy link
Member

@NicoKiaru if you click on the merge commit of this PR (c7aa9f4), you'll see only master but no tags in the subtitle:

image

... meaning that this commit is not (yet) part of any release of scijava-common. We first need a release of this component, then a version bump in pom-scijava, then a release of a new pom-scijava. Until then, you'll have to pin to a SNAPSHOT release for development.

@NicoKiaru
Copy link
Contributor Author

Thanks as always @imagejan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants