-
Notifications
You must be signed in to change notification settings - Fork 52
Fix array types with generics #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix array types with generics #416
Conversation
bda08b2
to
fbdb08b
Compare
Also add minimal test for array types with generics. See scijava#415
fbdb08b
to
cfe7db4
Compare
@hinerm if you find the time, may I ask you to have a look at this? See the linked issues for context. |
This was a delightfully effortless PR to review and merge. Thank you so much @imagejan, @NicoKiaru, @frauzufall! |
@hinerm do you know if this fix made its way in pom-scijava 30.0.0 ? Or is it planned for 30.0.1 ? Or is it unrelated ? |
@NicoKiaru if you click on the merge commit of this PR (c7aa9f4), you'll see only ... meaning that this commit is not (yet) part of any release of |
Thanks as always @imagejan ! |
Adds a test that reproduces the issue #415
The test CommandArrayConverterTest#testArrayConvertFromStringCommandWildcardGenerics currently fails