Using the style to format number in the swing UI. #52
Conversation
made usage of format flexible
reverted pom change
There was a problem hiding this comment.
Thanks a lot, @BoudewijnvanLangerak, for your suggestions. In my opinion, it makes a lot of sense to allow setting the format of numeric inputs via the style parameter as you propose.
If @ctrueden agrees in principle to what I've done in scijava/scijava-common#384 so far, I'd like to include the proposed change of this pull request into that other PR.
| for (final String s : widgetStyle.split(",")) { | ||
| if (s.startsWith("format:")) { | ||
| format = s.substring(s.indexOf(":") + 1).trim(); | ||
| } | ||
| } |
There was a problem hiding this comment.
With scijava/scijava-common#384, I tried to centralize parsing of the style attribute into a WidgetStyle class (as proposed by @ctrueden) and to fix some related issues, such as inconsistent handling of spaces with style definitions.
To keep the code base as DRY as possible, I suggest relying on that WidgetStyle class instead of this getFormat implementation. The latter would be specific to scijava-ui-swing whereas the former would allow usage from any UI implementation.
There was a problem hiding this comment.
@imagejan , basically that does sound like a good idea, but that PR has been open since April. We would rather have this be merged and available sometime soon and when your widget style becomes available, start using it as of then.
We are however not sure what the release cycle is. Is there a chance we can get this code released earlier if we keep it contained to just ui-swing?
There was a problem hiding this comment.
I merged scijava/scijava-common#384 and released scijava-common 2.85.0. @sunsear @BoudewijnvanLangerak Could you please add <scijava-common.version>2.85.0</scijava-common.version> to the POM on this branch, and try to implement @imagejan's suggestions? I'll then try to get this PR merged quickly. I'm sorry I'm so slow merging PRs—I maintain too many things, and so the release cycle of everything suffers.
There was a problem hiding this comment.
With scijava/scijava-common#405, it should be possible to replace this getFormat() method by a call to:
WidgetStyle.getStyleModifier(model.getItem().getWidgetStyle(), "format")
While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon, for cases like "format:#0.001". See also scijava/scijava-ui-swing#52.
While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon, for cases like "format:#0.001". See also scijava/scijava-ui-swing#52.
| for (final String s : widgetStyle.split(",")) { | ||
| if (s.startsWith("format:")) { | ||
| format = s.substring(s.indexOf(":") + 1).trim(); | ||
| } | ||
| } |
There was a problem hiding this comment.
With scijava/scijava-common#405, it should be possible to replace this getFormat() method by a call to:
WidgetStyle.getStyleModifier(model.getItem().getWidgetStyle(), "format")| @@ -119,6 +119,11 @@ else if (model.isStyle(NumberWidget.SLIDER_STYLE)) { | |||
| final SpinnerNumberModel spinnerModel = | |||
| new SpinnerNumberModelFactory().createModel(value, min, max, stepSize); | |||
| spinner = new JSpinner(spinnerModel); | |||
| String format = getFormat(model); | |||
| if (format != null) { | |||
| spinner.setEditor(new JSpinner.NumberEditor(spinner, format)); | |||
There was a problem hiding this comment.
It would be great to have some sensible guessing on the format (based on min, max and/or default value) in case format is null here.
While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon, for cases like "format:#0.001". See also scijava/scijava-ui-swing#52.
While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon, for cases like "format:#0.001". See also scijava/scijava-ui-swing#52.
|
I'm now closing this PR in favor of #54 that includes these changes. |
While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon, for cases like "format:#0.001". See also scijava/scijava-ui-swing#52.
Using the style to format number in the swing UI.