Skip to content

tests: test-core, pybind11 in full test #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryiii wants to merge 3 commits into
base: main
Choose a base branch
from
+37 −26
Open

tests: test-core, pybind11 in full test #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f284855
tests: test-core, pybind11 in full test
henryiii Dec 23, 2025
746ead1
ci: drop numpy from Cygwin job
henryiii Dec 25, 2025
df6f52e
style: pre-commit fixes
pre-commit-ci[bot] Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .distro/python-scikit-build-core.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ cp -p src/scikit_build_core/_vendor/pyproject_metadata/LICENSE LICENSE-pyproject

%generate_buildrequires
export HATCH_METADATA_CLASSIFIERS_NO_VERIFY=1
%pyproject_buildrequires -g test%{?with_optional_tests:,test-meta,test-numpy,test-pybind11}
%pyproject_buildrequires -g test-core%{?with_optional_tests:,test-parallel,test-meta,test-numpy,test-pybind11}
Copy link
Collaborator

@LecrisUT LecrisUT Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than test-schema (which seems more fitting in dev), is there any group from test that should not be added?



%build
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ jobs:

- name: Install min requirements
run: |
uv pip install -e. --group=test-pybind11 --resolution=lowest-direct --system
uv pip install -e. --group=test --resolution=lowest-direct --system

- name: Setup CMake 3.15
uses: jwlawson/[email protected]
Expand Down Expand Up @@ -223,7 +223,7 @@ jobs:
run: python3.13t -m venv /venv

- name: Install deps
run: /venv/bin/pip install -e . --group=test-pybind11 ninja
run: /venv/bin/pip install -e . --group=test ninja

- name: Test package
run: /venv/bin/pytest
Expand All @@ -246,7 +246,9 @@ jobs:
cmake ninja git make gcc-g++ python39 python39-devel python39-pip

- name: Install
run: python3.9 -m pip install . --group=test-pybind11
run:
python3.9 -m pip install . --group=test-core --group=test-pybind11
--group=test-parallel --group=test-schema --group=test-meta
Copy link
Collaborator

@LecrisUT LecrisUT Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could at least document why this one has a special group set?


- name: Test package
run:
Expand Down Expand Up @@ -279,7 +281,7 @@ jobs:
persist-credentials: false

- name: Install
run: python -m pip install . --group=test-pybind11
run: python -m pip install . --group=test

- name: Test package
run: >-
Expand Down Expand Up @@ -312,7 +314,7 @@ jobs:
persist-credentials: false

- name: Install
run: python -m pip install . --group=test-pybind11
run: python -m pip install . --group=test

- name: Test package
run: >-
Expand Down
47 changes: 28 additions & 19 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ hatch.scikit-build = "scikit_build_core.hatch.hooks"


[dependency-groups]
test = [
test-core = [
"build >=0.8",
"cattrs >=22.2",
"filelock >=3.8",
Expand All @@ -84,7 +84,6 @@ test = [
"pip>=24.1; python_version>='3.13'",
"pytest >=7.2",
"pytest-subprocess >=1.5",
'pytest-xdist >=3.1',
'setuptools >=43; python_version<"3.9"',
'setuptools >=45; python_version=="3.9"',
'setuptools >=49; python_version>="3.10" and python_version<"3.12"',
Expand All @@ -93,37 +92,47 @@ test = [
"virtualenv >=20.20",
"wheel >=0.40",
]
test-parallel = [
{ include-group = "test-core" },
'pytest-xdist >=3.1',
]
test-meta = [
{ include-group = "test" },
{ include-group = "test-core" },
"hatch-fancy-pypi-readme>=23.2",
"setuptools-scm",
"setuptools-scm>=5",
]
test-numpy = [
{ include-group = "test" },
"numpy; python_version<'3.14' and platform_python_implementation!='PyPy' and (platform_system != 'Windows' or platform_machine != 'ARM64')",
"numpy~=1.24.0; python_version=='3.8' and platform_python_implementation=='PyPy'",
"numpy~=2.0.0; python_version=='3.9' and platform_python_implementation=='PyPy'",
"numpy~=2.2.0; python_version=='3.10' and platform_python_implementation=='PyPy'",
]
test-schema = [
{ include-group = "test" },
"fastjsonschema",
"validate-pyproject",
{ include-group = "test-core" },
"numpy>=1.24; python_version<'3.15' and platform_python_implementation!='PyPy' and (platform_system != 'Windows' or platform_machine != 'ARM64')",
"numpy~=1.24; python_version=='3.8' and platform_python_implementation=='PyPy'",
"numpy~=2.0; python_version=='3.9' and platform_python_implementation=='PyPy'",
"numpy~=2.2; python_version=='3.10' and platform_python_implementation=='PyPy'",
"numpy~=2.4; python_version=='3.11' and platform_python_implementation=='PyPy'",
]
test-pybind11 = [
{ include-group = "test" },
{ include-group = "test-core" },
"pybind11 >=2.11",
]
test-schema = [
{ include-group = "test-core" },
"fastjsonschema>=2.16.2",
"validate-pyproject>=0.21",
]
test = [
{ include-group = "test-core" },
{ include-group = "test-meta" },
{ include-group = "test-numpy" },
{ include-group = "test-parallel" },
{ include-group = "test-pybind11" },
{ include-group = "test-schema" },
]
cov = [
{ include-group = "test" },
"pytest-cov",
]
dev = [
{ include-group = "cov" },
{ include-group = "test-meta" },
{ include-group = "test-numpy" },
{ include-group = "test-pybind11" },
{ include-group = "test-schema" },
{ include-group = "test" },
"rich",
]
docs = [
Expand Down
2 changes: 1 addition & 1 deletion tests/plans.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
node-date: 2025-02-27T16:18:39-05:00
describe-name: v0.11.0
EOF
pip install --user . --group=test-pybind11
pip install --user . --group=test
discover:
how: fmf
filter: "tag: pytest"
Expand Down
Loading