Repository navigation
Conversation
henryiii
force-pushed
the
fix/multidimensional-pdf-midpoints
branch
from
November 13, 2026 22:48
c620cb5 to
7c749b2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multidimensional
BinnedNLLandExtendedBinnedNLLwithuse_pdf="approximate"pass a grid-shaped array to the model instead of the documented(D, N)points. A scipy-style PDF usingpdf(xy.T)can fail on rectangular histograms or silently swap fitted means on square ones.Flatten the bin midpoints like the CDF path, then reshape the PDF values back to the histogram. The multidimensional PDF output is now shape-checked like the CDF output. The 1D path is unchanged.
Added regression cases for both costs using a non-square histogram. They fail on the base and pass with the fix. Locally: 633 tests passed, 109 skipped (optional dependencies and one platform skip); pinned Ruff and pre-commit-style mypy checks pass. Also checked uneven 3D bins, masks, weighted histograms and a fitted 2D Gaussian against the CDF result.
The native core was reused from the 2.33.0 wheel; C++/CMake sources and the ROOT pin match the base. No fresh native build or additional platform matrix was run.
Prepared with AI assistance.