[MRG+1] EHN: scikit-learn API transition

[glemaitre]

closes #460

This PR implements:

• Removing sample.
• Having a single fit_resample. In addition, we kept an alias fit_sample for backcompatibility.
• Sample X and y and any additional array of the same size.

[pep8speaks]

Hello @glemaitre! Thanks for updating the PR.

• In the file examples/applications/porto_seguro_keras_under_sampling.py, following are the PEP8 issues :

Line 27:1: E402 module level import not at top of file
Line 28:1: E402 module level import not at top of file
Line 29:1: E402 module level import not at top of file
Line 51:1: E402 module level import not at top of file
Line 52:1: E402 module level import not at top of file
Line 53:1: E402 module level import not at top of file
Line 54:1: E402 module level import not at top of file
Line 55:1: E402 module level import not at top of file
Line 56:1: E402 module level import not at top of file
Line 86:1: E402 module level import not at top of file
Line 93:1: E402 module level import not at top of file
Line 94:1: E402 module level import not at top of file
Line 128:1: E402 module level import not at top of file
Line 129:1: E402 module level import not at top of file
Line 148:1: E402 module level import not at top of file
Line 163:1: E402 module level import not at top of file
Line 185:1: E402 module level import not at top of file
Line 220:1: E402 module level import not at top of file
Line 221:1: E402 module level import not at top of file

Comment last updated on August 27, 2018 at 22:06 Hours UTC

[glemaitre]

@chkoar This will be a huge one difficult to review :)

I tried to keep it lean.

[glemaitre]

If you can have a look at it.

[codecov]

Codecov Report

Merging #462 into master will decrease coverage by 0.04%.
The diff coverage is 99.3%.

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   98.78%   98.74%   -0.05%     
==========================================
  Files          75       75              
  Lines        4628     4543      -85     
==========================================
- Hits         4572     4486      -86     
- Misses         56       57       +1

Impacted Files	Coverage Δ
imblearn/utils/tests/test_validation.py	100% <ø> (ø)	⬆️
imblearn/utils/__init__.py	100% <ø> (ø)	⬆️
...pling/_prototype_selection/_one_sided_selection.py	100% <100%> (ø)	⬆️
imblearn/datasets/_imbalance.py	100% <100%> (ø)	⬆️
...sampling/_prototype_selection/tests/test_allknn.py	100% <100%> (ø)	⬆️
imblearn/over_sampling/tests/test_adasyn.py	100% <100%> (ø)	⬆️
imblearn/ensemble/tests/test_balance_cascade.py	100% <100%> (ø)	⬆️
imblearn/over_sampling/tests/test_smote.py	100% <100%> (ø)	⬆️
...ling/_prototype_selection/_random_under_sampler.py	100% <100%> (ø)	⬆️
imblearn/combine/_smote_tomek.py	100% <100%> (ø)	⬆️
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c4196...6189206. Read the comment docs.

[mrastgoo]

add # noqa in the imports of the notebook style examples so that PEP8 stop complaining

[massich]

Implement the last part in a separate PR (and link to this one)

[glemaitre]

@chkoar @massich @mrastgoo Any reviews?