Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new transformer.get_feature_names_out function #248

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Prev Previous commit
set minimum version for scikit learn to 1.1.0
ragrawal committed Aug 8, 2022
commit 65ae37657d1efa5df08981374cfaba6b056822f4
2 changes: 1 addition & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ def lint(session):

@nox.session
@nox.parametrize('numpy', ['1.18.1', '1.20.1'])
@nox.parametrize('sklearn', ['1.0', '1.1.2'])
@nox.parametrize('sklearn', ['1.1.0', '1.1.2'])
@nox.parametrize('scipy', ['1.6.0'])
@nox.parametrize('pandas', ['1.2.2'])
def tests(session, numpy, sklearn, scipy, pandas):
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ def run(self):
packages=['sklearn_pandas'],
keywords=['scikit', 'sklearn', 'pandas'],
install_requires=[
'scikit-learn>=1.0.0',
'scikit-learn>=1.1.0',
'scipy>=1.5.1',
'pandas>=1.1.4',
'numpy>=1.19.4'
4 changes: 2 additions & 2 deletions tests/test_dataframe_mapper.py
Original file line number Diff line number Diff line change
@@ -468,8 +468,8 @@ def test_pca(complex_dataframe):
transformed = mapper.fit_transform(df)
cols = transformed.columns
assert len(cols) == 2
assert cols[0] == 'feat1_feat2_0'
assert cols[1] == 'feat1_feat2_1'
assert cols[0] == 'feat1_feat2_pca0'
assert cols[1] == 'feat1_feat2_pca1'


def test_fit_transform(simple_dataframe):