Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of six #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s-t-e-v-e-n-k
Copy link

This package has an undeclared requirement on six, but since Python 2 is long unsupported, remove it and just use the Python 3 idiom.

This package has an undeclared requirement on six, but since Python 2 is
long unsupported, remove it and just use the Python 3 idiom.
@a-detiste
Copy link

It's broken on Debian too, I'm using your patch
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1084379

@a-detiste
Copy link

More specificaly: I broke it indirrectly by removing six elsewhere

@s-t-e-v-e-n-k
Copy link
Author

      File "/<<PKGBUILDDIR>>/sklearn_pandas/pipeline.py", line 1, in <module>
        import six
    ModuleNotFoundError: No module named 'six'

This appears that you haven't applied the patch, that's the only file this PR changes.

@a-detiste
Copy link

I mean, it's moslty likely visible because I patched-out six from dateutil or some other low level library that was pulled in with sklean-pandas
https://wiki.debian.org/Python3-six-removal

sklearn-pandas is patched & uploadded right now
https://salsa.debian.org/science-team/sklearn-pandas/-/pipelines/814959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants