Skip to content

Commit

Permalink
Fix helm charts.
Browse files Browse the repository at this point in the history
We use prefix `redhat-` in helm charts

Signed-off-by: Petr "Stone" Hracek <[email protected]>
  • Loading branch information
phracek committed Feb 14, 2025
1 parent 934f046 commit b50dc24
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
14 changes: 8 additions & 6 deletions test/test_redis_shared_helm_imagestreams.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
class TestHelmRHELRedisImageStreams:

def setup_method(self):
package_name = "redis-imagestreams"
package_name = "redhat-redis-imagestreams"
path = test_dir
self.hc_api = HelmChartsAPI(path=path, package_name=package_name, tarball_dir=test_dir)
self.hc_api.clone_helm_chart_repo(
Expand All @@ -23,13 +23,15 @@ def teardown_method(self):
self.hc_api.delete_project()

@pytest.mark.parametrize(
"version,registry",
"version,registry,expected",
[
("6-el8", "registry.redhat.io/rhel8/redis-6:latest"),
("6-el9", "registry.redhat.io/rhel9/redis-6:latest"),
("6-el8", "registry.redhat.io/rhel8/redis-6:latest", True),
("6-el9", "registry.redhat.io/rhel9/redis-6:latest", True),
("7-el9", "registry.redhat.io/rhel9/redis-7:latest", True),
("7-el8", "registry.redhat.io/rhel8/redis-7:latest", False),
],
)
def test_package_imagestream(self, version, registry):
def test_package_imagestream(self, version, registry, expected):
assert self.hc_api.helm_package()
assert self.hc_api.helm_installation()
assert self.hc_api.check_imagestreams(version=version, registry=registry)
assert self.hc_api.check_imagestreams(version=version, registry=registry) == expected
8 changes: 4 additions & 4 deletions test/test_redis_shared_helm_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
class TestHelmRedisPersistent:

def setup_method(self):
package_name = "redis-persistent"
package_name = "redhat-redis-persistent"
path = test_dir
self.hc_api = HelmChartsAPI(path=path, package_name=package_name, tarball_dir=test_dir)
self.hc_api = HelmChartsAPI(path=path, package_name=package_name, tarball_dir=test_dir, shared_cluster=True)
self.hc_api.clone_helm_chart_repo(
repo_url="https://github.com/sclorg/helm-charts", repo_name="helm-charts",
subdir="charts/redhat"
Expand All @@ -35,10 +35,10 @@ def teardown_method(self):
self.hc_api.delete_project()

def test_package_persistent_by_helm_chart_test(self):
self.hc_api.package_name = "redis-imagestreams"
self.hc_api.package_name = "redhat-redis-imagestreams"
self.hc_api.helm_package()
assert self.hc_api.helm_installation()
self.hc_api.package_name = "redis-persistent"
self.hc_api.package_name = "redhat-redis-persistent"
self.hc_api.helm_package()
assert self.hc_api.helm_installation(
values={
Expand Down

0 comments on commit b50dc24

Please sign in to comment.