Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable Automatic Merge of Approved Pull Requests #308

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Jul 15, 2024

Add automation that will merge approved PRs with passed CI checks automatically.

It uses the following GitHub Actions:

Here are some examples of use from the systemd source-git. Please notice the Pull Request validation and Auto Merge sections:

Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, But I would suggest you to create a composite GitHub action for sclorg that would call:

  • redhat-plumbers-in-action/gather-pull-request-metadata@v1
  • redhat-plumbers-in-action/pull-request-validator@v2
  • redhat-plumbers-in-action/auto-merge@v2
  • redhat-plumbers-in-action/issue-commentator@v1

It should make the maintenance of automation easier since it should be in one place.
Here is an example for inspiration: https://github.com/redhat-plumbers-in-action/source-git-automation/blob/main/action.yml

@phracek
Copy link
Member Author

phracek commented Jul 15, 2024

I agree, but let's test it on two containers and later on we will decide whether we will use it in all repositories.

@phracek phracek merged commit f434588 into master Jul 15, 2024
1 check passed
@phracek phracek deleted the enable_automerge branch July 15, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants