Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #452 openssl-devel-engine is depreceted in Fedora, C10S. #458

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Fixes: #452 openssl-devel-engine is depreceted in Fedora, C10S. #458

merged 3 commits into from
Nov 15, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Oct 17, 2024 •
edited by github-actions bot
Loading

This issue fixes CentOS Stream failures for version 22.
The commit contains also references why it was deprecated.

Closes #452

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Pull Request validation

Failed

🔴 Failed or pending statuses - Testing Farm - RHEL9 - PyTest - OpenShift 4 - 18[error],Testing Farm - RHEL8 - PyTest - OpenShift 4 - 18[error]
🔴 Review - Missing review from a member (2 required)

Success

🟢 Review - Reviewed by undefined

@phracek
Copy link
Member Author

phracek commented Oct 17, 2024

[test]

@phracek
Copy link
Member Author

phracek commented Oct 17, 2024

@pacostas Please take a look at it. It should fix it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
RHEL9 - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 11:55:2916min 36stest pipeline
RHEL9 - 18RHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 11:55:2717min 57stest pipeline
RHEL9 - 22RHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 11:58:3123min 18stest pipeline
RHEL8 - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed08.11.2024 09:09:0119min 7stest pipeline
RHEL8 - 18RHEL-8.10.0-Nightlyx86_64✅ passed08.11.2024 09:08:5819min 23stest pipeline
RHEL9 - 20RHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 11:55:3918min 53stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed07.11.2024 11:58:3313min 12stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed08.11.2024 09:08:5922min 15stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64✅ passed07.11.2024 11:56:1818min test pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed07.11.2024 12:01:4112min 34stest pipeline
Fedora - 18-minimalFedora-latestx86_64✅ passed08.11.2024 09:09:001h 36min 55stest pipeline
RHEL9 - 22-minimalRHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:02:3017min 20stest pipeline
RHEL9 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 11:55:4923min 57stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed07.11.2024 11:56:2218min 45stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed07.11.2024 11:55:2717min 35stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 11:55:4727min 11stest pipeline
Fedora - 18Fedora-latestx86_64✅ passed08.11.2024 09:08:591h 39min 33stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed08.11.2024 09:09:011h 42min 13stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed07.11.2024 11:55:4224min 7stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed07.11.2024 11:55:4524min 30stest pipeline
RHEL8 - PyTest - OpenShift 4 - 16RHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:20:1513min 26stest pipeline
RHEL9 - PyTest - OpenShift 4 - 16RHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:15:4512min test pipeline
RHEL9 - PyTest - OpenShift 4 - 16-minimalRHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:20:2712min 1stest pipeline
RHEL8 - PyTest - OpenShift 4 - 16-minimalRHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:15:4412min 15stest pipeline
RHEL9 - PyTest - OpenShift 4 - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:23:3013min 59stest pipeline
RHEL8 - PyTest - OpenShift 4 - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:21:1416min 15stest pipeline
RHEL9 - PyTest - OpenShift 4 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:32:4514min 9stest pipeline
RHEL9 - PyTest - OpenShift 4 - 18RHEL-9.4.0-Nightlyx86_64❌ error11.11.2024 07:56:011h 55min 50stest pipeline
RHEL8 - PyTest - OpenShift 4 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:28:4815min 41stest pipeline
RHEL8 - PyTest - OpenShift 4 - 18RHEL-8.10.0-Nightlyx86_64❌ error11.11.2024 07:56:021h 57min 57stest pipeline
RHEL9 - PyTest - OpenShift 4 - 20RHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:28:4933min 13stest pipeline
RHEL9 - OpenShift 4 - 18RHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:12:3419min 4stest pipeline
RHEL8 - PyTest - OpenShift 4 - 20RHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:23:4633min 50stest pipeline
RHEL9 - OpenShift 4 - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:13:5820min 25stest pipeline
RHEL8 - OpenShift 4 - 18RHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:12:3423min 26stest pipeline
RHEL9 - OpenShift 4 - 20RHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:13:5518min 24stest pipeline
RHEL8 - OpenShift 4 - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:12:3322min 45stest pipeline
RHEL9 - OpenShift 4 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed07.11.2024 12:14:4819min 18stest pipeline
RHEL8 - OpenShift 4 - 20RHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:14:3422min 53stest pipeline
RHEL8 - OpenShift 4 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed07.11.2024 12:14:5723min 1stest pipeline

@phracek
Copy link
Member Author

phracek commented Oct 17, 2024

[test]

@pacostas
Copy link
Contributor

The tests do not pass due to rm: cannot remove '/tmp/tmp.xxxxxx/./tmp.xxxxxxx.cid': No such file or directory error which seems to happen randomly and not related to the changes of this PR. I'm not quite sure how this can be resolved. It seems like rerunning the tests will pass, or do you think is something we should spend some time looking at?

@phracek
Fixes: #452 openssl-devel-engine is depreceted in Fedora, C10S.
bd8bf0f 
See:

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Do not run the test 'test_run_binary_application' only
0c3abfc 
for CentOS Stream 10

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Nov 6, 2024

Rebased against master

[test-all]

@phracek
Rename testing Helm charts to the latest ones.
7dab8c6 
Container-ci-suite is not ready for switching between cluster

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Nov 7, 2024

[test-all]

mhdawson
mhdawson reviewed Nov 13, 2024
View reviewed changes
test/test-lib-nodejs.sh
echo "openssl-devel-engine is deprecated. Test is skipped."
return 0
fi
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this makes sense. After some pestering the maintainers of librdkakfa (on which node-rdkafka depends) have agreed to make the required fix but who knows when that will actually happen - https://github.com/nhaq-confluent

mhdawson
mhdawson approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phracek phracek merged commit 09bf01b into master Nov 15, 2024
40 of 42 checks passed
@phracek phracek deleted the fix_c10s branch November 15, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lholmquist lholmquist Awaiting requested review from lholmquist

@SlouchyButton SlouchyButton Awaiting requested review from SlouchyButton

Assignees
No one assigned
Labels
bug easyfix P1 pr/failing-ci pr/missing-review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CentOS Stream 22 is failling in `test_run_binary_applidation
3 participants
@phracek @pacostas @mhdawson