-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed dependencies issue #133
Conversation
@Yash621, can you verify that with this change the app will still work? We had an issue in map component where it actually did not work on RN > 0.58 |
@Yash621, upgrading the modules to latest is a must that we should do and I have no issue with it. I was wondering whether with this upgrade other components need to be updated too. There might be small chance that there are other dependencies that should be updated along with this other than just updating RN and React. And regarding the mentioned issue, there is no enough information. Could you just add more info(something like the debug log) to the issue so that we can ensure this dependency upgrade is a must that should be done at this moment. |
@@ -7,10 +7,11 @@ | |||
"test": "jest --detectOpenHandles -u" | |||
}, | |||
"dependencies": { | |||
"@hapi/joi": "^17.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was Unnecessary Dependency added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the reason, but don't worry I will revert that :)
Ps: I am digging deep into the issues faced by all the other students as many students are facing a lot of issues while setting up the project, and will make a guide soon for all the errors and their solutions :)
This PR is with respect to issue #132
In
package.json
we have to update the version ofreact-native
from0.58.6
to0.60.6
otherwisereact-native-fbsdk
throws dependencies issues.Likewise we have to upgrade the version of
react
from16.12.0
to16.8.6
to makenpm install
work.@shehand Please review it and let me know if any changes are required.