Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dependencies issue #133

Closed
wants to merge 4 commits into from
Closed

fixed dependencies issue #133

wants to merge 4 commits into from

Conversation

Yash621
Copy link
Contributor

@Yash621 Yash621 commented Feb 23, 2022

This PR is with respect to issue #132

In package.json we have to update the version of react-native from 0.58.6 to 0.60.6 otherwise react-native-fbsdk throws dependencies issues.

Likewise we have to upgrade the version of react from 16.12.0 to 16.8.6 to make npm install work.

@shehand Please review it and let me know if any changes are required.

@Yash621 Yash621 requested a review from shehand as a code owner February 23, 2022 18:50
@shehand
Copy link
Collaborator

shehand commented Mar 5, 2022

@Yash621, can you verify that with this change the app will still work? We had an issue in map component where it actually did not work on RN > 0.58

@Yash621
Copy link
Contributor Author

Yash621 commented Mar 5, 2022

@shehand can you look into this issue #131 ,without making these changes I was unable to run the app, but after doing these changes I am running in the issue #131 .

@shehand
Copy link
Collaborator

shehand commented Mar 6, 2022

@Yash621, upgrading the modules to latest is a must that we should do and I have no issue with it. I was wondering whether with this upgrade other components need to be updated too. There might be small chance that there are other dependencies that should be updated along with this other than just updating RN and React. And regarding the mentioned issue, there is no enough information. Could you just add more info(something like the debug log) to the issue so that we can ensure this dependency upgrade is a must that should be done at this moment.

@Yash621
Copy link
Contributor Author

Yash621 commented Mar 6, 2022

@shehand I have fixed that issue by downgrading react-native version to ^0.60.0.
after that I ran into this issue #134 ,but I fixed it, and also have posted a solution of it in this issue #134 ,so that it could be helpful for others

@@ -7,10 +7,11 @@
"test": "jest --detectOpenHandles -u"
},
"dependencies": {
"@hapi/joi": "^17.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was Unnecessary Dependency added?

Copy link
Contributor Author

@Yash621 Yash621 Mar 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the reason, but don't worry I will revert that :)
Ps: I am digging deep into the issues faced by all the other students as many students are facing a lot of issues while setting up the project, and will make a guide soon for all the errors and their solutions :)

@Yash621 Yash621 closed this Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants