Generate the report only after the tests have run #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a functional test phase in our project build, using Scoverage. Our use case is that we want to run both types of test, and generate a single aggregate report. Our build looks like:
The new "ScoverageITest" mode doesn't fit our use case. I've added some code comments explaining the issues, but I haven't attempted to fix it. |
| // The coverage report will be additive in that case. | ||
| // | ||
| // TODO: this feature needs some thought to be more useful. | ||
| // The following use cases are not currently supported: |
There was a problem hiding this comment.
(I suppose this isn't quite correct -- it will more or less work, but you'll generate the report twice and throw away one, which seems wasteful)
|
Also fixes #29 |
|
(Don't merge yet: this is broken, sorry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #31