Update scala-xml to 2.0.0 #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
commented
May 20, 2021
Comment on lines
+320
to
+329
| val customXML: XMLLoader[Elem] = XML.withSAXParser { | ||
| val factory = SAXParserFactory.newInstance() | ||
| factory.setFeature( | ||
| "http://apache.org/xml/features/nonvalidating/load-external-dtd", | ||
| false | ||
| ) | ||
| factory.newSAXParser() | ||
| } | ||
|
|
||
| val xml = customXML.loadFile(fileIn(dir)) |
There was a problem hiding this comment.
This needed to change in order to account for scala/scala-xml#177. I'm not super worried about this seeing that we are only using this parser to test here.
|
So scala-xml is no longer published for 2.11, which is annoying seeing that we just added support back in for 2.11.12. This basically leaves us with 3 options:
|
|
Included in #384. This will be merge into the 2.0 branch due to 2.0 not supporting 2.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.