Skip to content

Implement aggregation prover (Compression Circuit part) #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jul 6, 2023
Merged

Implement aggregation prover (Compression Circuit part) #158

merged 32 commits into from
Jul 6, 2023

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Jun 26, 2023 •
edited
Loading

Related Compression Circuit PR scroll-tech/zkevm-circuits#568

Test

  • make test-chunk-prove could pass.
  • make test-comp-prove could pass.

Summary

  • Add struct aggregator Prover, and Compression snark and EVM proof generation functions.
  • Add struct aggregator Verifier, and snark and EVM proof verification functions.
  • Rename aggregation_tests.rs to chunk_tests.rs and add compression_tests.rs (e2e).
  • Delete params download function (always use load_params or params downsize).
  • Merge wip v0.4 #159 into this PR.

@silathdiir silathdiir marked this pull request as draft June 26, 2023 14:36
@icemelon icemelon force-pushed the refactor-zkevm-prover branch from e8dac26 to fea2692 Compare June 27, 2023 00:12
@silathdiir silathdiir force-pushed the impl-aggregation-prover branch from a9761a9 to 59594c4 Compare June 27, 2023 00:48
Base automatically changed from refactor-zkevm-prover to main June 28, 2023 06:29
@silathdiir silathdiir force-pushed the impl-aggregation-prover branch from 620fc18 to 38d0330 Compare June 29, 2023 03:41
silathdiir and others added 22 commits June 29, 2023 20:29
@silathdiir silathdiir changed the title [WIP] Implement aggregation prover [WIP] Implement aggregation prover (Compression Circuit part) Jul 6, 2023
@silathdiir silathdiir marked this pull request as ready for review July 6, 2023 08:45
@silathdiir silathdiir changed the title [WIP] Implement aggregation prover (Compression Circuit part) Implement aggregation prover (Compression Circuit part) Jul 6, 2023
@lispc lispc force-pushed the impl-aggregation-prover branch from c825d0c to eb7f948 Compare July 6, 2023 09:12
lispc
lispc approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough to be merged

@lispc lispc merged commit 461f402 into main Jul 6, 2023
@lispc lispc deleted the impl-aggregation-prover branch July 6, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lispc lispc lispc approved these changes

@zhenfeizhang zhenfeizhang Awaiting requested review from zhenfeizhang

@icemelon icemelon Awaiting requested review from icemelon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silathdiir @lispc