Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

fix: tx_type info is lost #192

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix: tx_type info is lost #192

merged 3 commits into from
Aug 3, 2023

Conversation

kunxian-xia
Copy link
Contributor

This pr aims to fix two issues.

  1. tx_type is not passed downward.
  2. we must use own fork of ethers which supports the RLP encoding & decoding of L1Msg tx.

This pr and scroll-tech/zkevm-circuits#710 together will fix the #190 issue.

@lispc lispc requested a review from silathdiir August 2, 2023 13:13
silathdiir
silathdiir approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@silathdiir silathdiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Testing on a server.

lispc
lispc approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be merged

@lispc lispc merged commit 89ee8c7 into main Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lispc lispc lispc approved these changes

@silathdiir silathdiir silathdiir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunxian-xia @lispc @silathdiir