Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout Changes
CopyCircuitConfig
Dream's design: https://hackmd.io/geYBzdKjRdmO948KCGnh-Q?view
Changes
address < addr_copy_start
.is_front_mask
implies a byte cell hasaddress < addr_copy_start
, which means it's a masked byte and won't be accumlated in the rlc value.Adds
address < addr_copy_end
.This strange naming is for disambiguation, since result needs to be opposite.
!is_not_back_mask
implies a byte cell hasaddress >= address_copy_end
, which means it's a masked byte and won't be accumlated in the rlc value.src_addr_end
>address
.The
addr_copy_end
might be larger thansrc_addr_end
.!is_inbound_read
implies a byte cell hasaddress >= src_addr_end
, which means it's a out-of-bound read, it's value should be 0.Removes
value_limbs
is_front_mask || !is_not_back_mask
!is_inbound_read
is_inbound_read
CopyTable
Adds
Changes
Constraint Changes
CopyCircuitConfig
value_acc == value_acc' + sum(value_i * !(is_front_mask || !is_not_back_mask))
!is_inbound_read
impliesvalue == 0