Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: word hi lo refactor stage2 #1069

Merged
merged 36 commits into from
Jan 23, 2024
Merged

feat: word hi lo refactor stage2 #1069

merged 36 commits into from
Jan 23, 2024

Conversation

DreamWuGit
Copy link

@DreamWuGit DreamWuGit commented Dec 20, 2023

Description

PI circuit

  • add rpi_rlc_acc_word column and assign
  • enable keccak lookup & start_state_root, end_state_root
  • update tx table value word changes
  • fix testing failures
  • todo: update after keccak table remove rlc_output with only output_word

tx circuit

  • update tx table value to word
  • update tx lookup & wrap word type
  • update is_zero_value applied to word
  • fix degree increase by 1
  • fix testing failures

sig circuit

  • add sig table msg_hash_word to word
  • handle pk_hash, sig_r_rlc, sig_s_rlc to word as well ?
  • todo: update after keccak table remove rlc_output with only output_word
  • fix testing failures

super circuit

  • enable previous disabled constraints & tests
  • update ux table (u8, u16 table) imported by state circuit hi lo refactoring
  • fix testing failures

aggregation circuit

  • need to figure out concrete changes required: if any keccak lookup ?
  • fix testing failures

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

@DreamWuGit DreamWuGit marked this pull request as ready for review January 9, 2024 07:27
@DreamWuGit
Copy link
Author

make ready for testing purpose.

@DreamWuGit
Copy link
Author

test pass now, will merge to stage1 .

@DreamWuGit DreamWuGit merged commit 727c20f into word_hi_lo Jan 23, 2024
@DreamWuGit DreamWuGit deleted the word_hi_lo_2 branch January 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant