Feat/zstd witgen compressed block #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roynalnaruto
requested changes
Jan 20, 2024
roynalnaruto
approved these changes
Feb 15, 2024
noel2004
pushed a commit
that referenced
this pull request
Apr 17, 2024
* reconsolidate messy code on working branch * correct huffman header processing * correct jump table * huffman code direct representation * reserve huffman header decoding * jump table correction * correct jump table type * delimitation of bitstream for accumulation witness * Finish decoding bitstreams * Add lstream decoding witness rows * Add witness rows for huffman bitstream decoding * remove constant from merge * Restore default witness value for correction * Remove decoded from FSE Huffman * correct jump table witness * Modify direct rep * correct fse witness * adjust test * Verify FSE interleaved decoding * tag fix * Remove accuracy log from auxiliary table * Consolidate huffman weights subroutine into one tag * correct size format parsing * add huffman code routine for recovering bitstring * remove imports * Add bitstream decoding test * complete unit test coverage of literal decoding * remove direct representation of huffman code * correct witness generation * Correct witness values * Correct idx incremental block * Correct tag next * Correct tag_idx * Correct tag value accumulator * Correct huffman data byte offset * Correct witness values * Remove import * Correct comments on decoding constants * Introduce tag_rlc * Correct multiplier for tag * Clean up and consolidate working example circuit assignment test * Assignment correction * Add column assignments * Organize constraint blocks * Recover constraints * Recover constraints * Add tag change assignment * Recover constraints * Recover constraints * Recover constraints * Recover constraints * Recover constraints * Recover constraints * Recover constraints * Recover constraints * Recover constraints * Adjust constraint blocks * Reassign comparator * Recover constraints * Recover constraints * Recover constraints * Correct Constraints * Correct constraints * Correct constraints * Annotate test data * Resolve merge issues * Examine constraints * Assign lstream config * Recover constraints * Recover constraints * Recover constraints * Add more bitstream witnesses * Recover constraints * Recover constraints * Remove comments * Correct tag_rlc_acc constraint and assignment * Correct tag_rlc constraints and assignment * Correct tag_rlc constraint and assignments: * Recover constraints * Adjust huffman code idx * Revert "Adjust huffman code idx" This reverts commit d8b5107. * Correct byte delimitation in the test * Recover constraints * Recover constraints * Assign block gadget * Recover constraints * Recover constraints * Recover constraints * Recover constraints * Correct tag value acc again * Recover constraints * Correct decoding constraints * Correct assignment for fcs * Rand power correction * Correct constraints * Correct fcs * Correct block header * Correct tag lookup * Recover constraint * Recover constraint * Recover constraints * Recover constraint * Correct lookup * Correct witness values * Bitstream decoder idx transition fix * Correct FSE processing * Cover fse section in bitstream transition * Correct Value RLC * format * Add FSE decoding * Add more assignments * Complete witness fix * Correct size calculation * Correct bit boundary assignment * Correct FSE counting * Correct FSE transition * Correct accuracy log bit reading * Recover constraints * Recover constraints * Recover constraints * Recover constraints * Assign into bitstream accumulation for spanned * Recover lookups * Construct contained bitstreams * Recdover lookups * Recover lookups * Remove debug flags * Correct n_acc for FSE * LiteralHeader decomposition * Add dummy row * Restore state * FSE initial condition * Remove debug flags * Correct constraint * Assign fse table * Recover lookup * Recover lookup * Recover lookup * Recover lookup * Add comments * Recover constraint * Remove debug flag * assignment to LiteralsHeaderTable * introduce is_nil for bitstream_decoder that is set when no bits are read * todo: debug * Add comment * Remove comment * Correct bit boundaries reconstruction * Adjust constraints * Correct bitstring accumulation constraints * Fix fse table lookup * Add conditions to fix lookups * Remove debug flag * Correct branch assignment * Remove debug flag * Organize constraints * fmt * fmt again * literals header lookup fix * clippy * clippy * clippy * Clippy * clippy * decoded literals table | refactor tables module --------- Co-authored-by: Rohit Narurkar <[email protected]> Co-authored-by: Rohit Narurkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate witness rows for zstd decompression circuit for a zstd-compressed block
Issue Link
[link issue here]
Type of change
Contents
Rationale
[design decisions and extended information]
How Has This Been Tested?
[explanation]
How to fill a PR description
Please give a concise description of your PR.
The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.
MUST: Reference the issue to resolve
Single responsability
Is RECOMMENDED to create single responsibility commits, but not mandatory.
Anyway, you MUST enumerate the changes in a unitary way, e.g.
Design choices
RECOMMENDED to: