Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

add comment to explain rlp_unsigned_bytes #1367

Merged
lispc merged 4 commits into from
Jul 19, 2024
Merged

add comment to explain rlp_unsigned_bytes #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e05ccdc
add comment for rlp_unsigned_bytes
DreamWuGit Jul 18, 2024
bc0f2e9
Merge branch 'develop' into rlp_unsigned_bytes_comment
DreamWuGit Jul 18, 2024
5eab594
rename chain_id
DreamWuGit Jul 18, 2024
e70fd6a
Merge branch 'rlp_unsigned_bytes_comment' of https://github.com/scrol…
DreamWuGit Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bus-mapping/src/circuit_input_builder/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ pub struct Transaction {
pub signature: Signature,
/// RLP bytes
pub rlp_bytes: Vec<u8>,
/// RLP bytes for signing
/// RLP bytes for signing, only used for PreEip155 tx without chain_id
/// for other tx types: rlp == rlp_unsigned.
pub rlp_unsigned_bytes: Vec<u8>,
/// RLP bytes for signed tx
pub rlp_signed_bytes: Vec<u8>,
Expand Down
3 changes: 2 additions & 1 deletion eth-types/src/geth_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ pub struct Transaction {

/// RLP bytes
pub rlp_bytes: Vec<u8>,
/// RLP unsigned bytes
/// RLP unsigned bytes, only used for PreEip155 tx without chain_id
/// for other tx types: rlp == rlp_unsigned.
pub rlp_unsigned_bytes: Vec<u8>,
// TODO: add rlp_signed_bytes as well ?
/// Transaction hash
Expand Down