Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Detect constraint failure early in recursion circuit #1369

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

noel2004
Copy link
Member

It is useness to run the proof of circuit if the equality constraints is not met in assigment step. So we detect them eariler.

@noel2004 noel2004 requested a review from roynalnaruto July 18, 2024 05:38
@roynalnaruto
Copy link

@noel2004 do you want to change the base branch to develop? Post-merging I will cherry-pick the commit into release/v0.12.0.

@noel2004
Copy link
Member Author

@noel2004 do you want to change the base branch to develop? Post-merging I will cherry-pick the commit into release/v0.12.0.

Ok

@noel2004 noel2004 changed the base branch from release/v0.12.0 to develop July 18, 2024 09:32
@noel2004 noel2004 force-pushed the feat/recursion_fail_detective branch from 531d684 to 3fe82be Compare July 18, 2024 09:34
@noel2004 noel2004 marked this pull request as ready for review July 18, 2024 09:35
@noel2004 noel2004 changed the title [FEAT] Detec constraint failure early in recursion circuit [FEAT] Detect constraint failure early in recursion circuit Jul 18, 2024
Copy link

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roynalnaruto roynalnaruto merged commit 75d6bf6 into develop Jul 18, 2024
32 checks passed
@roynalnaruto roynalnaruto deleted the feat/recursion_fail_detective branch July 18, 2024 10:56
roynalnaruto pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants