Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chunk is padding circuit #686

Conversation

zhenfeizhang
Copy link

Description

#670 (comment)

First of all, the is_smaller_than rely on some assumption that both operands are small, but both the num_of_valid_chunks and value are private cells.

num_of_valid_chunks is a public input https://github.com/scroll-tech/zkevm-circuits/blob/static-proof-aggregation/aggregator/src/aggregation/circuit.rs#L380-L386
rlc_config.load_private(region, &Fr::from(i as u64), offset)?; missed a copy constraint from fixed column. should have loaded a constant 1 and accumulate from there. will fix

this is the fix

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • fix soundness bug in chunk_is_valid function

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@zhenfeizhang zhenfeizhang requested a review from kunxian-xia July 28, 2023 11:48
@zhenfeizhang zhenfeizhang self-assigned this Jul 28, 2023
@zhenfeizhang zhenfeizhang changed the base branch from develop to 711-remove-num_chunks-from-public-input August 3, 2023 14:20
@kunxian-xia kunxian-xia self-requested a review August 4, 2023 03:20
@zhenfeizhang
Copy link
Author

closed as integrated to #712

@zhenfeizhang zhenfeizhang deleted the fix-chunk-is-padding-circuit branch August 4, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants