Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stack reconstruct #993

Merged
merged 90 commits into from
Feb 7, 2024
Merged

feat: stack reconstruct #993

merged 90 commits into from
Feb 7, 2024

Conversation

lightsing
Copy link
Member

@lightsing lightsing commented Oct 7, 2023 •
edited
Loading

Changes

  • env CHECK_MEM_STRICT changes to CHECK_MEM_STACK_LEVEL

@lightsing lightsing force-pushed the feat/stack-reconstruct branch 5 times, most recently from 9454828 to 5a3fdc6 Compare October 7, 2023 14:27
@lightsing lightsing force-pushed the feat/stack-reconstruct branch 4 times, most recently from c356c4c to 737d959 Compare October 8, 2023 08:42
@lispc
Copy link

lispc commented Oct 8, 2023 •
edited
Loading

after this finished, we can bench some ccc time. i guess deserialize time will be reduced a lot

oh this can be next PR. Add a stack_head to trace struct.

@lightsing lightsing force-pushed the feat/stack-reconstruct branch 7 times, most recently from 9dd299b to 0052b3b Compare October 10, 2023 02:36
@lightsing lightsing force-pushed the feat/stack-reconstruct branch from f6dd701 to 2e52052 Compare October 17, 2023 04:35
@lightsing lightsing force-pushed the feat/stack-reconstruct branch from 2e52052 to 273baa2 Compare October 17, 2023 04:39
@lightsing lightsing force-pushed the feat/stack-reconstruct branch 2 times, most recently from d9495da to 8784bcc Compare October 17, 2023 07:35
@lispc lispc changed the title [wip] stack reconstruct feat: stack reconstruct Jan 31, 2024
@lispc
Copy link

lispc commented Jan 31, 2024

looks good to me. I will run testool later today then merge it.

@lispc
Copy link

lispc commented Feb 1, 2024 •
edited
Loading

@lightsing a lot failures. I would suggest check these failed precompiles like ecmul_1-2_616_28000_96_d0_g0_v0.

https://circuit-release.s3.us-west-2.amazonaws.com/testool/nightly.1706707610.0cecef0.html

@lightsing
Copy link
Member Author

default suit: https://circuit-release.s3.us-west-2.amazonaws.com/testool/default.1707280178.9aef6df.html
checked: all failed case are not present in test_ids.txt

@lightsing lightsing merged commit d622d66 into develop Feb 7, 2024
15 checks passed
@lightsing lightsing deleted the feat/stack-reconstruct branch February 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lispc lispc lispc approved these changes

Assignees
No one assigned
Labels
crate-bus-mapping crate-eth-types crate-external-tracer crate-mock crate-zkevm-circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lightsing @lispc @DreamWuGit