Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cell line meta data class #539

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Update cell line meta data class #539

merged 2 commits into from
Feb 19, 2024

Conversation

wxicu
Copy link
Collaborator

@wxicu wxicu commented Feb 19, 2024

PR Checklist

  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

  • Metadata classes should load data more lazily Metadata classes should load data more lazily #478: __init__ loads only the ones that are requested on annotate. The remainig files are downloaded upon request of annotating. However, all the files are forced to be downloaded when initializing the lookup object. Thus it takes much more time to initialize the look up object if all the files haven't downloaded before. Do you probably have any other suggestions?
  • Improve annotate docstring in cell line Improve annotate docstring in cell line #479: Add Cancerxgene in the docstring. Also, rename all the downloaded files and their corresponding variables to be more readable.

Technical details

Additional context

@wxicu wxicu requested a review from Zethson February 19, 2024 13:37
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it's okay if everything is downloaded when a lookup object is created. That's just the original behavior so whatever.

@Zethson Zethson merged commit 05caae8 into main Feb 19, 2024
7 checks passed
namsaraeva pushed a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants