Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): import skimage early in scublets without threshold #3463

Merged
merged 5 commits into from
Feb 18, 2025
Merged

(fix): import skimage early in scublets without threshold #3463

merged 5 commits into from
Feb 18, 2025

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Feb 12, 2025 •
edited
Loading

  • Release notes not necessary because: No behavior change

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (3075537) to head (e20b106).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3463   +/-   ##
=======================================
  Coverage   75.44%   75.45%           
=======================================
  Files         113      113           
  Lines       13250    13251    +1     
=======================================
+ Hits         9997     9998    +1     
  Misses       3253     3253
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_scrublet/__init__.py 96.84% <100.00%> (+0.03%) ⬆️

@ilan-gold ilan-gold added this to the 1.12.0 milestone Feb 12, 2025
@flying-sheep flying-sheep modified the milestones: 1.12.0, 1.11.1 Feb 18, 2025
@flying-sheep flying-sheep merged commit ad9e3b8 into main Feb 18, 2025
18 checks passed
@flying-sheep flying-sheep deleted the ig/skimage_import branch February 18, 2025 09:51
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 18, 2025
Merged
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Feb 18, 2025
@ilan-gold @meeseeksmachine
Backport PR scverse#3463: (fix): import skimage early in scublets…
ac49bb3 
… without `threshold`
flying-sheep pushed a commit that referenced this pull request Feb 18, 2025
@meeseeksmachine @ilan-gold
Backport PR #3463: (fix): import skimage early in scublets withou…
ae9fa46 
…t `threshold` (#3470)

Co-authored-by: Ilan Gold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.1
Development

Successfully merging this pull request may close these issues.

Dependency issue: sc.pp.scrublet require skimage implicitly
2 participants
@ilan-gold @flying-sheep