Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3462 on branch 1.11.x ((chore): Simplify BasePlot’s var_groups) #3471

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #3462: (chore): Simplify BasePlot’s var_groups

@lumberbot-app lumberbot-app bot added this to the 1.11.1 milestone Feb 18, 2025
@flying-sheep flying-sheep enabled auto-merge (squash) February 18, 2025 10:25
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 80.85106% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.50%. Comparing base (a28fe88) to head (241e755).
Report is 2 commits behind head on 1.11.x.

Files with missing lines Patch % Lines
src/scanpy/plotting/_baseplot_class.py 80.43% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           1.11.x    #3471      +/-   ##
==========================================
+ Coverage   75.44%   75.50%   +0.05%     
==========================================
  Files         113      113              
  Lines       13250    13318      +68     
==========================================
+ Hits         9997    10056      +59     
- Misses       3253     3262       +9     
Files with missing lines Coverage Δ
src/scanpy/neighbors/_connectivity.py 85.96% <100.00%> (ø)
src/scanpy/plotting/_baseplot_class.py 89.56% <80.43%> (-1.99%) ⬇️

... and 1 file with indirect coverage changes

@flying-sheep flying-sheep merged commit 9d8b4a9 into scverse:1.11.x Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants