(fix): remove @wraps(BaseException.add_note)
#3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilan-gold
commented
Feb 21, 2025
ilan-gold
commented
- Closes 3.11 Tests Don't Run #3475
- Tests included or not required because: This functionality is already tested
- Release notes not necessary because: Not important enough :/
ilan-gold
changed the title
@wraps(BaseException.add_note)@wraps(BaseException.add_note)
|
I'm not sure why this was broken, but it was. This is only used in one place and will go away once we bump to 3.11 so I don't really have the energy to investigate further |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3477 +/- ##
==========================================
- Coverage 75.40% 75.40% -0.01%
==========================================
Files 113 113
Lines 13260 13259 -1
==========================================
- Hits 9999 9998 -1
Misses 3261 3261
|
|
whew, this seems like a doozy, nice work! |
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Feb 21, 2025
flying-sheep
pushed a commit
that referenced
this pull request
Feb 21, 2025
) Co-authored-by: Ilan Gold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.