3.x: Clean up the mocks after DnsEndpointTest #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncheck
force-pushed
the
test-fixes-3
branch
2 times, most recently
from
fabe6c5 to
464b0b9
Compare
Adds an `@AfterClass` method that cleans up the custom resolver. Previously it was possible that the mocked hostname would still be associated with the same ip in another test, causing it to fail in certain cases.
Bouncheck
force-pushed
the
test-fixes-3
branch
from
464b0b9 to
1c2fa74
Compare
dkropachev
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
@AfterClassmethod that cleans up the custom resolver.Previously it was possible that the mocked hostname would still be associated
with the same ip in another test, causing it to fail in certain cases.