-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes for CICD #414
Small fixes for CICD #414
Conversation
cb74c95
to
c03c832
Compare
@fruch , I want to remove Amongst all drivers python-driver pipeline is the most |
it's idea was to start testing before there's a release, if it doesn't do nothing now, it's not really |
With another distro, you never know, another libc, another environment, python has too many dependancies, unless you test it, you never know. But, don't we do run tests in Build and upload to PyPi ? |
we didn't even build 3.13 yet, when he built. and now we should have 3.14 (https://www.python.org/downloads/release/python-3140a1/) almost pre-release. |
Oh, you mean that you want to have a github workflow to enable testing on upcoming python version ? |
Yes, that's what this flow was for I created it for python 3.13 before it was released |
Apart from the removal of build-prerelease it looks fine. |
Let's make it manually triggerable and don't run it in PRs no to polute statuses and later make it pull current pre-prelease and run on it, WDYT ? |
As I said before, If we allocate time for testing it, I'm o.k. with ditching the pipeline. one can test it locally even, but if we don't, we for sure are gonna hit by it Also the other builds, I think we can remove some of the options, and put them under the label, for example windows / Mac, or aarch64, but before release we need a swipe on those, other release would fail |
ba5e2ce
to
576c1ca
Compare
it is needed only to test comptibility with next release before it is released, having it in regular CICD will polute PR status with something that have nothing to do with PR. @Lorak-mmk, @fruch , please take a look again, I have made build and push workflow reusable and reused it for both regular build and pre-releases. |
576c1ca
to
e02a462
Compare
1. Make it reuse `lib-build-and-push` 2. Make it manually triggerable only This workflow is checking if driver works with next pre-release python version. We don't want to have them in PRs, if it fails it does not mean that PR is bad. It would be better to manually trigger it for now, and later we will make it check on existing pre-release versions and run on them once a month.
e02a462
to
08432e5
Compare
build-pre-release.yml
Pre-review checklist
I added relevant tests for new features and bug fixes.All commits compile, pass static checks and pass test.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/
.I added appropriateFixes:
annotations to PR description.