core: function_traits noexcept specializations #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avikivity
reviewed
Feb 3, 2025
| @@ -57,6 +57,21 @@ template <typename T, typename Ret, typename... Args> | |||
| struct function_traits<Ret(T::*)(Args...) const> : public function_traits<Ret(Args...)> | |||
| {}; | |||
|
|
|||
| #if __cplusplus >= 201703L | |||
There was a problem hiding this comment.
You can drop this #ifdef, Seastar support C++20 and C++23 only.
There was a problem hiding this comment.
@avikivity , is there anything else that needs improvement?
starting from 17th standard noexcept-specification is a part of the function type. function_traits doesn't have specializations for noexcept function types thus cannot resolve the traits. adding noexcept specializations allows function_traits for a larger class of function types fi noexcept future exception continuations. seastar supports 20th standard and newer thus there is no need to worry about compatibility.
Comrade88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting from 17th standard noexcept-specification is a part of the function type. function_traits doesn't have specializations
for noexcept function types thus cannot resolve the traits.
adding noexcept specializations allows function_traits for a larger class of function types fi noexcept future exception continuations. seastar supports 20th standard and newer thus there is no need to worry about compatibility.