Skip to content

rpc: Tune up connection methods visibility #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
+5 −1
Merged

rpc: Tune up connection methods visibility #3064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion include/seastar/rpc/rpc.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ protected:
future<> stream_close();
future<> stream_process_incoming(rcv_buf&&);
future<> handle_stream_frame();
future<> send_negotiation_frame(feature_map features);

public:
connection(connected_socket&& fd, const logger& l, void* s, connection_id id = invalid_connection_id) : connection(l, s, id) {
Expand All @@ -319,10 +320,11 @@ public:
}

void set_socket(connected_socket&& fd);
future<> send_negotiation_frame(feature_map features);
bool error() const noexcept { return _error; }
void abort();
future<> stop() noexcept;

private:
future<> stream_receive(circular_buffer<foreign_ptr<std::unique_ptr<rcv_buf>>>& bufs);
future<> close_sink() {
_sink_closed = true;
Expand All @@ -341,6 +343,8 @@ public:
}
return make_ready_future();
}

public:
connection_id get_connection_id() const noexcept {
return _id;
}
Expand Down