headers: Remove smp.hh from app-template.hh #3066
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs it for std::shared_ptr<smp> field, but can just go with forward declaration. The smp_options.hh carried the resource::cpuset indirectly via this inclusion, no it needs to include resource.hh explicitly. Signed-off-by: Pavel Emelyanov <[email protected]>
xemul
force-pushed
the
br-smphh-remove-from-apptemplate
branch
from
977073b to
a506a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs it for std::shared_ptr field, but can just go with forward declaration. The smp_options.hh carried the resource::cpuset indirectly via this inclusion, no it needs to include resource.hh explicitly.