Skip to content

Added vBase with no styles #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Added vBase with no styles #57

merged 3 commits into from
Apr 13, 2020

Conversation

dolbex
Copy link
Contributor

@dolbex dolbex commented Sep 20, 2019

Sarah, thanks for the wonderful package. If we could add this vbase with no styles that would be awesome. loader does some things when styles is present but is empty that we have to avoid in our build routine and this would save us some highlight+delete time :)

@sdras
Copy link
Owner

sdras commented Sep 20, 2019

Oh sure! Can you please add a reference to it in the readme? That's what people use as reference. After that, we're good to merge. Thanks!

@dolbex
Copy link
Contributor Author

dolbex commented Sep 23, 2019

Awesome, I'll get this in there tonight!

@sdras
Copy link
Owner

sdras commented Sep 25, 2019

Can you please resolve your conflicts? Thanks!

@dolbex
Copy link
Contributor Author

dolbex commented Sep 25, 2019

Updated along with the README. Apologies on the delay.

@sdras
Copy link
Owner

sdras commented Apr 13, 2020

Thank you!

@sdras sdras merged commit d20add6 into sdras:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants