refactor: make tests framework agnostic #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed dependencies; tests fail
# Conflicts: # README.md # boomerangPDS/pom.xml # idealPDS/pom.xml
swissiety
changed the title
# Conflicts: # SparseBoomerangCorrectness/pom.xml # SynchronizedPDS/pom.xml # SynchronizedPDS/src/main/java/sync/pds/solver/OneWeightFunctions.java # SynchronizedPDS/src/main/java/sync/pds/solver/SyncPDSSolver.java # WPDS/pom.xml # WPDS/src/main/java/wpds/impl/WeightedPAutomaton.java # WPDS/src/main/java/wpds/impl/WeightedPushdownSystem.java # boomerangPDS/pom.xml # boomerangPDS/src/main/java/boomerang/WeightedBoomerang.java # boomerangPDS/src/main/java/boomerang/WeightedForwardQuery.java # boomerangPDS/src/main/java/boomerang/callgraph/BoomerangResolver.java # boomerangPDS/src/main/java/boomerang/debugger/ConsoleDebugger.java # boomerangPDS/src/test/java/test/cases/fields/ReadPOITest.java # boomerangPDS/src/test/java/test/cases/fields/WritePOITest.java # boomerangScope-Soot/src/main/java/boomerang/framework/soot/jimple/JimpleDeclaredMethod.java # boomerangScope-Soot/src/main/java/boomerang/framework/soot/jimple/JimpleMethod.java # boomerangScope-Soot/src/main/java/boomerang/framework/soot/jimple/JimpleStaticFieldVal.java # boomerangScope-WALA/pom.xml # boomerangScope-WALA/src/main/java/boomerang/framework/wala/WALADeclaredMethod.java # boomerangScope-WALA/src/main/java/boomerang/framework/wala/WALAMethod.java # boomerangScope/pom.xml # idealPDS/pom.xml # idealPDS/src/main/java/typestate/TransitionFunction.java # idealPDS/src/main/java/typestate/impl/statemachines/OutputStreamStateMachine.java # idealPDS/src/test/java/typestate/test/helper/File.java # pom.xml # testCore/pom.xml
|
… callgraph on every call of this actual getter method
…t the scope objects of Soot
# Conflicts: # boomerangPDS/pom.xml # boomerangPDS/src/main/java/boomerang/guided/DemandDrivenGuidedAnalysis.java # boomerangPDS/src/test/java/boomerang/guided/CustomFlowFunctionTest.java # boomerangPDS/src/test/java/test/cases/bugfixes/Repro.java
swissiety
force-pushed
the
feature/sootup-support-refactor
branch
from
bdfbe0b to
36a069a
Compare
smeyer198
reviewed
Feb 10, 2025
There was a problem hiding this comment.
The things that I have marked come from the silent code clean up. I would keep them as before to avoid changing the intended tests. I will have a closer look at them anyway, when refactoring the BoomerangOptions (i.e. isStringBuilderOrBuffer() and things like this).
Another point: Maybe can rename the scope packages boomerang.framework.soot etc. into boomerang.scope.soot etc. (replace 'framework' with 'scope')? IMO, it is easier to describe it in the documentation, something like: "Boomerang works on its on scope, we provide a scope for Soot, SootUp, ..." and then the imports lead to the correct scopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
future work on that matter is noted in #42
TODO: