Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

price impact error clarity #121

Merged
merged 3 commits into from
Mar 29, 2024
Merged

price impact error clarity #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bc844c
feat: price impact error clarity
AustinWoetzel Mar 29, 2024
80f593f
fix: typo causing failed tests
AustinWoetzel Mar 29, 2024
def9038
Merge pull request #120 from securesecrets/price-impact-error-improve…
AustinWoetzel Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-taxis-pay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@shadeprotocol/shadejs": patch
---

clarity around price impact error
2 changes: 1 addition & 1 deletion src/lib/swap/stableswapCurve/stable.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ test('slippage calculations correct', () => {

// slippage limit
conf = getConfSmallPool();
expect(() => conf.swapToken0WithToken1(BigNumber(100000000))).toThrowError(/^The slippage of this trade.*/);
expect(() => conf.swapToken0WithToken1(BigNumber(100000000))).toThrowError(/^The price impact of this trade.*/);
});

test('py correct', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/swap/stableswapCurve/stable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ export class StableConfig {
tradeDirIs0For1,
});
if (priceImpact.isGreaterThan(this.priceImpactLimit) || priceImpact.isLessThan(BigNumber(0))) {
throw Error(`The slippage of this trade is outside of the acceptable range of 0% - ${this.priceImpactLimit}%.`);
throw Error(`The price impact of this trade (${priceImpact.toString()}%) is outside of the acceptable range of 0% - ${this.priceImpactLimit}%.`);
}
}

Expand Down
Loading