Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked Logger copy ctors as deleted. #1714

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Dimi1010
Copy link
Collaborator

Closes #1708

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.11%. Comparing base (3292f14) to head (de43b0c).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1714      +/-   ##
==========================================
- Coverage   83.11%   83.11%   -0.01%     
==========================================
  Files         279      279              
  Lines       48399    48399              
  Branches    10237    10502     +265     
==========================================
- Hits        40227    40226       -1     
- Misses       7035     7050      +15     
+ Partials     1137     1123      -14     
Flag Coverage Δ
alpine320 75.07% <ø> (-0.01%) ⬇️
fedora40 75.10% <ø> (ø)
macos-13 80.60% <ø> (+<0.01%) ⬆️
macos-14 80.60% <ø> (ø)
macos-15 80.57% <ø> (ø)
mingw32 70.73% <ø> (-0.11%) ⬇️
mingw64 70.78% <ø> (-0.03%) ⬇️
npcap 85.20% <ø> (-0.03%) ⬇️
rhel94 74.96% <ø> (+<0.01%) ⬆️
ubuntu2004 58.59% <ø> (ø)
ubuntu2004-zstd 58.71% <ø> (ø)
ubuntu2204 74.87% <ø> (-0.01%) ⬇️
ubuntu2204-icpx 61.27% <ø> (ø)
ubuntu2404 75.11% <ø> (ø)
unittest 83.11% <ø> (-0.01%) ⬇️
windows-2019 85.24% <ø> (-0.01%) ⬇️
windows-2022 85.27% <ø> (-0.01%) ⬇️
winpcap 85.24% <ø> (ø)
xdp 50.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete or private the copy constructors for pcpp::Logger to prevent accidental copies.
2 participants