Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joystick Interposer Fixes for SDL, wine, Retroarch and RPCS3 #173

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

danisla
Copy link
Member

@danisla danisla commented Jan 21, 2025

Changes

  • Fixes joystick interposer compatibility with Retroarch, wine, and RPCS3.
  • Intercepts calls to open64 and makes socket non-blocking when added to an epoll.
  • Implements support for interposing /dev/input/event* joystick devices.
  • The SDL_JOYSTICK_DEVICE workaround for SDL apps is no longer needed.

Application Specific

Retroarch

To use with retroarch, edit your retroarch.cfg (at ~/.config/retroarch/retroarch.cfg) and set:

input_joypad_driver = "linuxraw"

RPCS3

Select SDL as controller handler then select Selkies Controller 1 from the device list.
Screenshot from 2025-02-07 00-08-58

Wine

Run wine control and then open the Game Controllers app to test joystick support.
Screenshot from 2025-02-07 00-10-19


Current work in progress:

  • Attempt to interpose evdev to support SDL.

@danisla danisla marked this pull request as draft January 22, 2025 07:14
@danisla danisla changed the title Fix issues with joystick interposer and Retroarch Joystick Interposer Fixes for SDL, wine, Retroarch and RPCS3 Feb 7, 2025
@ehfd ehfd self-requested a review February 7, 2025 08:26
@ehfd
Copy link
Member

ehfd commented Feb 7, 2025

@danisla Feel free to switch from Draft PR if you are ready.

@danisla
Copy link
Member Author

danisla commented Feb 7, 2025

@danisla Feel free to switch from Draft PR if you are ready.

@ehfd I temporarily remove the Conga build steps because they were failing, can you help resolve the errors? You can run the conga docker build locally and see the same failures.

@ehfd
Copy link
Member

ehfd commented Feb 7, 2025

That is in order for the near future. I know the source of error.

@danisla
Copy link
Member Author

danisla commented Feb 7, 2025

That is in order for the near future. I know the source of error.

Ok maybe we’ll just leave it disabled for now and you can re-enable it the build steps later.

@ehfd
Copy link
Member

ehfd commented Feb 7, 2025

Anyways, when you are ready, press "Ready for review" and I'll directly make necessary edits.

@danisla danisla marked this pull request as ready for review February 7, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants