Skip to content

fix: allow assets to be false #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+41 −22
Open

fix: allow assets to be false #402

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd4c557
fix: allow assets to be false
JoshuaKGoldberg Dec 13, 2022
cdde211
remove some unnecessary test data
JoshuaKGoldberg Dec 13, 2022
81e477d
even less test stuff
JoshuaKGoldberg Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions lib/prepare.js
View file
Original file line number Diff line number Diff line change
@@ -32,29 +32,32 @@ module.exports = async (pluginConfig, context) => {

const modifiedFiles = await getModifiedFiles({env, cwd});

const filesToCommit = uniq(
await pReduce(
assets.map((asset) => (!isArray(asset) && isPlainObject(asset) ? asset.path : asset)),
async (result, asset) => {
const glob = castArray(asset);
let nonegate;
// Skip solo negated pattern (avoid to include every non js file with `!**/*.js`)
if (glob.length <= 1 && glob[0].startsWith('!')) {
nonegate = true;
debug(
'skipping the negated glob %o as its alone in its group and would retrieve a large amount of files ',
glob[0]
);
}
const filesToCommit =
assets && assets.length > 0
? uniq(
await pReduce(
assets.map((asset) => (!isArray(asset) && isPlainObject(asset) ? asset.path : asset)),
async (result, asset) => {
const glob = castArray(asset);
let nonegate;
// Skip solo negated pattern (avoid to include every non js file with `!**/*.js`)
if (glob.length <= 1 && glob[0].startsWith('!')) {
nonegate = true;
debug(
'skipping the negated glob %o as its alone in its group and would retrieve a large amount of files ',
glob[0]
);
}

return [
...result,
...micromatch(modifiedFiles, await dirGlob(glob, {cwd}), {dot: true, nonegate, cwd, expand: true}),
];
},
[]
)
);
return [
...result,
...micromatch(modifiedFiles, await dirGlob(glob, {cwd}), {dot: true, nonegate, cwd, expand: true}),
];
},
[]
)
)
: [];

if (filesToCommit.length > 0) {
logger.log('Found %d file(s) to commit', filesToCommit.length);
16 changes: 16 additions & 0 deletions test/prepare.test.js
View file
Original file line number Diff line number Diff line change
@@ -123,6 +123,22 @@ test('Commit files matching the patterns in "assets"', async (t) => {
t.deepEqual(t.context.log.args[0], ['Found %d file(s) to commit', 5]);
});

test('Commit no files when "assets" is false', async (t) => {
const {cwd, repositoryUrl} = await gitRepo(true);
const pluginConfig = {
assets: false,
};
const branch = {name: 'master'};
const options = {repositoryUrl};
const env = {};
const lastRelease = {};
const nextRelease = {version: '2.0.0', gitTag: 'v2.0.0'};

await prepare(pluginConfig, {cwd, env, options, branch, lastRelease, nextRelease, logger: t.context.logger});

t.deepEqual((await gitCommitedFiles('HEAD', {cwd, env})).sort(), []);
});

test('Commit files matching the patterns in "assets" as Objects', async (t) => {
const {cwd, repositoryUrl} = await gitRepo(true);
const pluginConfig = {