Split SemaphoreVerifier key points into a separate library #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split SemaphoreVerifier key points into a separate library
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
cedoor
reviewed
Oct 16, 2024
cedoor
requested changes
Oct 16, 2024
…or VerifierKeyPts lib
jimmychu0807
commented
Oct 16, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Semaphore Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
FaezehShakouri
pushed a commit
to FaezehShakouri/semaphore
that referenced
this pull request
Feb 1, 2025
…-protocol#875) * refactor(scripts): added a script to convert bigint to hex * refactor(contracts): split SemaphoreVerifier verification key points into a separate library (semaphore-protocol#330) * chore(contracts): yarn format & lint * refactor(contracts): update SemaphoreVerifierKeyPts library to be internal re semaphore-protocol#330 * chore(contracts): update spacing * chore(contracts): updated per peer review and added invariant check for VerifierKeyPts lib * chore(contracts): update invariant check to revert with custom error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split SemaphoreVerifier key points into a separate library and transform all verification key points into one big bytes constant.
Also added a small script that convert decimal bigint to hex string.
Related Issue(s)
Closes #330
Related: #345
Other information
gas cost collected from
yarn test:report-gas:Original:
With this PR:
@cedoor should I make a PR to semaphore
mainbranch, or some other branch?cc @saleel
Checklist
yarn formatandyarn lintwithout getting any errors