Merge pull request #465 from semgrep/brandon/java-named-ellipsis-param

chore: named ellipses in java
semgrep · Jan 23, 2024 · 326025a · 326025a
2 parents 40c10f7 + b43d552
commit 326025a
Show file tree

Hide file tree

Showing 2 changed files with 93 additions and 28 deletions.
diff --git a/lang/semgrep-grammars/src/semgrep-java/grammar.js b/lang/semgrep-grammars/src/semgrep-java/grammar.js
@@ -45,32 +45,38 @@ module.exports = grammar(base_grammar, {
     ),
 
     semgrep_ellipsis: $ => '...',
+    semgrep_named_ellipsis: $ => /\$\.\.\.[A-Z_][A-Z_0-9]*/,
+
 
     primary_expression: ($, previous) => choice(
       previous,
       $.semgrep_ellipsis,
+      $.semgrep_named_ellipsis
     ),
 
     statement: ($, previous) => choice(
       previous,
       $.semgrep_ellipsis,
+      $.semgrep_named_ellipsis
     ),
 
     formal_parameter: ($, previous) => choice(
       previous,
       $.semgrep_ellipsis,
+      $.semgrep_named_ellipsis
     ),
 
     _class_body_declaration: ($, previous) => choice(
       previous,
-      $.semgrep_ellipsis
+      $.semgrep_ellipsis,
+      $.semgrep_named_ellipsis
     ),
 
     partials: $ => choice(
        $.partial_method,
     ),
 
-    // partial of method_declaration 
+    // partial of method_declaration
     partial_method: $ => seq(
       optional($.modifiers),
       $._method_header

diff --git a/lang/semgrep-grammars/src/semgrep-java/test/corpus/semgrep.txt b/lang/semgrep-grammars/src/semgrep-java/test/corpus/semgrep.txt
@@ -19,16 +19,16 @@ bar();
 
 --------------------------------------------------------------------------------
 
-  (program
-    (expression_statement
-      (method_invocation
-        (identifier)
-        (argument_list)))
-    (semgrep_ellipsis)
-    (expression_statement
-      (method_invocation
-        (identifier)
-        (argument_list))))
+(program
+  (expression_statement
+    (method_invocation
+      (identifier)
+      (argument_list)))
+  (semgrep_ellipsis)
+  (expression_statement
+    (method_invocation
+      (identifier)
+      (argument_list))))
 
 ================================================================================
 Top level public constructor
@@ -72,15 +72,16 @@ public record $R(...) {
 }
 
 --------------------------------------------------------------------------------
+
 (program
-      (record_declaration
-        (modifiers)
-        (identifier)
-        (formal_parameters
-          (formal_parameter
-            (semgrep_ellipsis)))
-        (class_body
-          (semgrep_ellipsis))))
+  (record_declaration
+    (modifiers)
+    (identifier)
+    (formal_parameters
+      (formal_parameter
+        (semgrep_ellipsis)))
+    (class_body
+      (semgrep_ellipsis))))
 
 ================================================================================
 Method header
@@ -91,14 +92,14 @@ public int foo(...)
 --------------------------------------------------------------------------------
 
 (program
-      (partials
-        (partial_method
-          (modifiers)
-          (integral_type)
-          (identifier)
-          (formal_parameters
-            (formal_parameter
-              (semgrep_ellipsis))))))
+  (partials
+    (partial_method
+      (modifiers)
+      (integral_type)
+      (identifier)
+      (formal_parameters
+        (formal_parameter
+          (semgrep_ellipsis))))))
 
 ================================================================================
 Constructor body ellipsis
@@ -183,3 +184,61 @@ class $X {
             (variable_declarator
               (identifier)
               (identifier))))))))
+
+================================================================================
+Named ellipsis parameter
+================================================================================
+
+class $X {
+  void $ASDF($...PARAMS) {
+  }
+}
+
+--------------------------------------------------------------------------------
+
+(program
+  (class_declaration
+    (identifier)
+    (class_body
+      (method_declaration
+        (void_type)
+        (identifier)
+        (formal_parameters
+          (formal_parameter
+            (semgrep_named_ellipsis)))
+        (block)))))
+
+================================================================================
+Named ellipsis statements
+================================================================================
+
+foo();
+$...STMTS
+bar();
+
+--------------------------------------------------------------------------------
+
+(program
+  (expression_statement
+    (method_invocation
+      (identifier)
+      (argument_list)))
+  (semgrep_named_ellipsis)
+  (expression_statement
+    (method_invocation
+      (identifier)
+      (argument_list))))
+
+================================================================================
+Named ellipsis expression
+================================================================================
+
+1 + $...NAMED;
+
+--------------------------------------------------------------------------------
+
+(program
+  (expression_statement
+    (binary_expression
+      (decimal_integer_literal)
+      (semgrep_named_ellipsis))))