fix(security): auto audit fix - #1450
Merged
Merged
Conversation
sendbird-sdk-deployment-2
approved these changes
Aug 11, 2026
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… midnight CI flake `Build and Test` fails for ~3 minutes a day, just before midnight, on any branch. Run 31548322868 attempt 1 hit it at 23:57 UTC; attempt 2 passed at 00:30 UTC with no code change. `getMessagePartsInfo` derives `hasSeparator` from `isSameDay(current, previous)` — a calendar-day check that drives the date separator in the message list. The spec built its fixtures at `Date.now() + 1/2/3 minutes` and then asserted that all three sit on the same day. Whenever the suite was collected within three minutes of local midnight the fixtures straddled two days, `hasSeparator` flipped to true, and the "should not group messages if sent time are different" case failed. Pinning the base instant makes the fixtures deterministic. Verified by reproducing the exact CI assertion from a temp copy of the spec with the base set to 23:57:30, and by running the spec under UTC, UTC+14, UTC-12 and Asia/Seoul. The production logic is left alone: rendering a date separator across a midnight boundary is the intended behaviour, and the same `isSameDay` pattern is used in OpenChannelMessageList and ThreadList. Only the spec's undeclared same-day premise was wrong. The instant matches the one already used by MessageSearchItem.spec.js and MessageSearchFileItem.spec.js. Fake timers were not needed here because the unit under test never reads the system clock. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit Report
Repository:
sendbird/sendbird-uikit-reactPackage Manager:
yarn-berryProject:
.Date: 2026-08-11
Summary
Fixed Vulnerabilities
Remaining Vulnerabilities (requires manual review)
dirparameterfromis unsetChanged files
yarn.lockReview checklist