Bumping sensu-plugin version #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #78 |
|
@majormoses can I get a 👍/👎 on this? |
|
needs a changelog entry explaining the breaking changes but otherwise looks good. You can look at: sensu-plugins/sensu-plugins-docker@7ce5ba9 for refrence. |
|
I can do that and get it released this weekend if you don't beat me to getting that added. |
|
Looks like travis is clogged up but I cut a release. I will check back later and manually cut a rubygems release if it has not done it by then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
#78 , #45
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
New Plugins
Tests
Add the plugin to the README
Does it have a complete header as outlined here
Purpose
See details in #78 . Handler does its own filtering. Bumping up the gem resolves this.
Known Compatibility Issues
This is bumping up to 2.X, likely a breaking change.